feat(uploads): wrap agents and agents/revision endpoints#198
Merged
Conversation
Collaborator
|
@Valyrian-Code changes look good, could you rebase on the main branch? |
Refs fossology#52. Adds two read-only getters for the agents that have run on an upload: - upload_agents() -> GET /uploads/{id}/agents, returning a list[AgentOfUpload] (uploadId / agentName / currentAgentId / currentAgentRev / isAgentRunning / successfulAgents) - upload_agents_revision() -> GET /uploads/{id}/agents/revision, returning a list[AgentsRevision] (id / name / revision) Adds the AgentOfUpload and AgentsRevision models to obj.py following the existing from_json convention. Both methods raise AuthorizationError on HTTP 403, consistent with the other uploads endpoints. Verified against Fossology 4.4.0 (API 1.6.1) running in a container: all 7 tests pass (live happy paths, mocked payload/parse assertions, and 403/500 error paths). Signed-off-by: RAJVEER42 <irajveer.bishnoi2310@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: RAJVEER42 <irajveer.bishnoi2310@gmail.com>
Valyrian-Code
force-pushed
the
feat/upload-agents-info
branch
from
5a37422 to
2bf5599
Compare
Contributor
Author
|
@deveaud-m Done! I've rebased the branch on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #52.
Adds two read-only getters for the agents that have run on an upload:
upload_agents()→GET /uploads/{id}/agents— returnslist[AgentOfUpload](uploadId/agentName/currentAgentId/currentAgentRev/isAgentRunning/successfulAgents)upload_agents_revision()→GET /uploads/{id}/agents/revision— returnslist[AgentsRevision](id/name/revision)Adds the
AgentOfUploadandAgentsRevisionmodels toobj.py, following the existingfrom_jsonconvention. Both methods raiseAuthorizationErroron HTTP 403, consistent with the other uploads endpoints.API details
Verified against Fossology 4.4.0 (API 1.6.1) running in a container.
Tests
All 7 pass live: happy paths for both getters, mocked payload/parse assertions, and 403/500 error paths.
ruffandmypypass.