Add reversible External ID and safe GovCloud workflows - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
external-idmigration command for existing AWS setupsarn:aws-us-govrole partitionsonboard-accountsandsync-accountsfor reviewed standalone-account manifestsWhy
Forward's regular AWS collector can discover a GovCloud Organization, but federal customers may not grant Organizations access or may operate standalone accounts. The previous CLI also generated commercial-partition IAM ARNs when adding accounts and allowed a reviewed payload to bypass source-specific removal checks.
Safety behavior
--allow-removalsapply-planreloads current state and cannot bypass GovCloud removal controlsValidation
make cigo test -race ./...git diff --check