Skip to content

Fix date parsing crash on newer libc #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nyanpasu64 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix date parsing crash on newer libc #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2606483
Revert "Utils: comment out my_strptime wrapper"
nyanpasu64 Jul 8, 2026
ce26c44
Fix date parsing crash on newer libc
nyanpasu64 Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/Utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,18 +148,17 @@ int my_mkdir(const std::string& path, int perms)
char* my_strptime(const char* s,
const char* f,
struct tm* tm)
{
// just use normal strptime, the DIY implementation was being Weird
return strptime(s, f, tm);

// std::istringstream input(s);
// input.imbue(std::locale(setlocale(LC_ALL, nullptr)));
// input >> std::get_time(tm, f);
// if (input.fail())
// {
// return nullptr;
// }
// return (char*)(s + input.tellg());
try {
std::istringstream input(s);
input.imbue(std::locale::classic());
input >> std::get_time(tm, f);
if (input.fail())
{
return nullptr;
}
return (char*)(s + input.tellg());
} catch (...) {
return nullptr;
}

// http://stackoverflow.com/a/11366985
Expand Down
Loading