Skip to content

fix: strip component-level servers blocks before OpenAPI merge#1993

Closed
gfyrag wants to merge 1 commit into
release/v3.0from
fix/strip-component-servers-v2
Closed

fix: strip component-level servers blocks before OpenAPI merge#1993
gfyrag wants to merge 1 commit into
release/v3.0from
fix/strip-component-servers-v2

Conversation

@gfyrag
Copy link
Copy Markdown
Contributor

@gfyrag gfyrag commented Jun 1, 2026

Summary

  • Component specs declare their own servers block (http://localhost:8080/) which conflicts with base.yaml during the openapi-merge
  • This causes all operations to inherit an operation-level servers block while the root-level servers from base.yaml are lost
  • Adds a yq del(.servers) step in the Earthfile after copying component specs and before the merge, using find so any new component is automatically handled

Test plan

  • Run earthly +build-final-spec and verify root-level servers from base.yaml are present and no operation has an operation-level servers block

🤖 Generated with Claude Code

Component specs declare their own servers block (http://localhost:8080/)
which conflicts with base.yaml during the openapi-merge. This causes
every operation in the generated spec to inherit an operation-level
servers block, while the root-level servers from base.yaml are lost.

Add a strip step that removes servers from all component specs before
the merge, so only base.yaml servers survive at root level.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c2a2b13b-9156-48b5-b4e0-16fb46bd02b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/strip-component-servers-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gfyrag gfyrag closed this Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant