fix: strip component-level servers blocks before OpenAPI merge#1993
Closed
gfyrag wants to merge 1 commit into
Closed
fix: strip component-level servers blocks before OpenAPI merge#1993gfyrag wants to merge 1 commit into
gfyrag wants to merge 1 commit into
Conversation
Component specs declare their own servers block (http://localhost:8080/) which conflicts with base.yaml during the openapi-merge. This causes every operation in the generated spec to inherit an operation-level servers block, while the root-level servers from base.yaml are lost. Add a strip step that removes servers from all component specs before the merge, so only base.yaml servers survive at root level. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serversblock (http://localhost:8080/) which conflicts withbase.yamlduring the openapi-mergeserversblock while the root-level servers frombase.yamlare lostyq del(.servers)step in the Earthfile after copying component specs and before the merge, usingfindso any new component is automatically handledTest plan
earthly +build-final-specand verify root-level servers frombase.yamlare present and no operation has an operation-levelserversblock🤖 Generated with Claude Code