chore: replace benthos with redpanda/connect

[sylr]

No description provided.

[coderabbitai]

Warning

Review limit reached

@sylr, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 28 minutes and 21 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 67aa1e67-fa07-479c-a884-8cd0519d8ea7

📥 Commits

Reviewing files that changed from the base of the PR and between bc3f1ca and cbfda6d.

⛔ Files ignored due to path filters (1)

• tests/e2e/chainsaw/23-benthos-module/chainsaw-test.yaml is excluded by !**/*.yaml

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go

Walkthrough

The PR updates the Benthos image helper to use the Redpanda registry and changes the deployment to request the Benthos image with tag v4.93.0 (previously v4.23.1-es).

Changes

Benthos Image Update

Layer / File(s)	Summary
Image registry source update internal/resources/registries/image.go	GetBenthosImage now returns docker.redpanda.com/redpandadata/connect:<version> (version normalized via NormalizeVersion). Documentation comment for supported registry paths was shortened.
Deployment image tag update internal/resources/benthos/controller.go	createDeployment requests the Benthos image with tag v4.93.0 (replacing v4.23.1-es) when calling registries.GetBenthosImage.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through registries, sniffed the log,
From ECR trails to Redpanda fog,
A tag uplifted, neat and spry,
Benthos boots on version nine-three—hi! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: replace benthos with redpanda/connect' accurately describes the main change: replacing the Benthos container image with Redpanda Connect across the codebase.
Description check	✅ Passed	No pull request description was provided by the author; however, the change is sufficiently clear from the title and file summaries, making the absence of description acceptable for a straightforward dependency replacement.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/upgrade-benthos

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

internal/resources/registries/image.go (1)

14-14: ⚡ Quick win

Update documentation to reflect the actual registry pattern.

The documentation comment still references jeffail/, but the actual GetBenthosImage implementation now uses docker.redpanda.com/redpandadata/connect. Consider updating this line to reflect the new pattern or removing the outdated reference.

📝 Suggested documentation fix

-// public.ecr.aws/<organization>/jeffail/
+// docker.redpanda.com/<organization>/<repository>:<version>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/resources/registries/image.go` at line 14, The file-level doc
comment is out of date: replace or remove the stale registry reference "//
public.ecr.aws/<organization>/jeffail/" so it matches the actual image registry
used by GetBenthosImage (docker.redpanda.com/redpandadata/connect) — update the
comment to the new pattern or delete the line entirely to avoid misleading docs;
ensure the comment near GetBenthosImage clearly shows the current registry
pattern "docker.redpanda.com/redpandadata/connect".

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@internal/resources/registries/image.go`:
- Line 14: The file-level doc comment is out of date: replace or remove the
stale registry reference "// public.ecr.aws/<organization>/jeffail/" so it
matches the actual image registry used by GetBenthosImage
(docker.redpanda.com/redpandadata/connect) — update the comment to the new
pattern or delete the line entirely to avoid misleading docs; ensure the comment
near GetBenthosImage clearly shows the current registry pattern
"docker.redpanda.com/redpandadata/connect".

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca3d6124-d569-4d97-81f8-49b3f1dcf3d1

📥 Commits

Reviewing files that changed from the base of the PR and between 6ec3a86 and 8f0403d.

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go

[flemzord]

The comment does not match the line below.

[coderabbitai]

♻️ Duplicate comments (1)

internal/resources/registries/image.go (1)

14-14: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the incomplete registry format example.

Line 14 currently omits repository and version, so it no longer matches the accepted registry/image:<version> format documented around it.

Proposed fix

-// public.ecr.aws/<organization>/jeffail/
+// public.ecr.aws/<organization>/jeffail/benthos:<version>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@internal/resources/registries/image.go` at line 14, The example registry
string "public.ecr.aws/<organization>/jeffail/" is incomplete and should follow
the documented registry/image:<version> format; update the comment to include a
repository and tag (for example replace "public.ecr.aws/<organization>/jeffail/"
with "public.ecr.aws/<organization>/jeffail/<image>:<version>") so the example
in internal/resources/registries/image.go matches the accepted format.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@internal/resources/registries/image.go`:
- Line 14: The example registry string "public.ecr.aws/<organization>/jeffail/"
is incomplete and should follow the documented registry/image:<version> format;
update the comment to include a repository and tag (for example replace
"public.ecr.aws/<organization>/jeffail/" with
"public.ecr.aws/<organization>/jeffail/<image>:<version>") so the example in
internal/resources/registries/image.go matches the accepted format.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e778195e-3bdf-492c-b710-4f1886d67831

📥 Commits

Reviewing files that changed from the base of the PR and between 8f0403d and bc3f1ca.

⛔ Files ignored due to path filters (1)

• tests/e2e/chainsaw/23-benthos-module/chainsaw-test.yaml is excluded by !**/*.yaml

📒 Files selected for processing (2)

• internal/resources/benthos/controller.go
• internal/resources/registries/image.go