feat: add OtelExporterEndpoint crd#449
Conversation
|
Warning Review limit reached
More reviews will be available in 38 minutes and 32 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (9)
WalkthroughAdds an OtelExporterEndpoint CRD, generator for merged OpenTelemetry Collector configs, a controller reconciling per-stack Collector Deployment/Service/ConfigMap, settings integration for in-cluster collectors, CLI/platform wiring, unit and controller tests, and documentation. ChangesOtelExporterEndpoint CRD and Controller Implementation
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sofiasimdianova
changed the title
|
Dirty is not passing. Make sure to run |
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
2 times, most recently
from
b9260f3 to
3bfc797
Compare
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
2 times, most recently
from
cb99db5 to
b37ed89
Compare
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
b37ed89 to
de76074
Compare
sofiasimdianova
changed the title
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
de76074 to
6e38209
Compare
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
6e38209 to
c925b4f
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (4)
docs/09-Configuration reference/02-Custom Resource Definitions.md (1)
2267-2267: ⚡ Quick winDocument what
status.stackscontains.
stackscurrently has an empty description. Please describe that it lists the matched stack names for this endpoint (sorted), so operators can interpret status without reading controller code.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/09-Configuration` reference/02-Custom Resource Definitions.md at line 2267, The docs entry for status.stacks is missing a description; update the table row for `stacks` (status.stacks) to explain that it lists the matched stack names for this endpoint and that the list is returned in a stable sorted order so operators can interpret status without inspecting controller code (e.g., "Lists the matched stack names for this endpoint, returned as a sorted array of strings").api/formance.com/v1beta1/otelexporterendpoint_types.go (2)
29-34: ⚡ Quick winConsider adding URL format validation for the
Endpointfield.The
Endpointfield accepts any string without validation. Invalid URLs would only be caught during collector configuration generation or at runtime, reducing early feedback.🛡️ Suggested validation
type OtelSignalConfig struct { + // +kubebuilder:validation:Pattern=`^(https?|grpc)://.*$` Endpoint string `json:"endpoint"` // +optional Auth *OtelAuthConfig `json:"auth,omitempty"` }Note: The pattern can be adjusted based on accepted endpoint formats. The collector config generator currently handles
http://,https://,grpc://, and bare hostnames.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/formance.com/v1beta1/otelexporterendpoint_types.go` around lines 29 - 34, Add URL/hostname validation for the OtelSignalConfig.Endpoint field so invalid endpoints are caught at CRD validation time: update the OtelSignalConfig struct (type OtelSignalConfig) and add a kubebuilder validation marker above the Endpoint field (for example a +kubebuilder:validation:Pattern comment or +kubebuilder:validation:Format) that matches allowed schemes (http://, https://, grpc://) and bare hostnames; ensure the json tag remains `json:"endpoint"` and keep the Auth field unchanged.
23-27: ⚡ Quick winConsider adding validation for the
FromSecretfield.The
FromSecretfield references a Kubernetes secret name but has no validation markers. WhenTypeis"bearer", an emptyFromSecretwould cause runtime failures during auth token lookup.🛡️ Suggested validation
type OtelAuthConfig struct { // +kubebuilder:validation:Enum=bearer Type string `json:"type"` + // +kubebuilder:validation:MinLength=1 FromSecret string `json:"fromSecret"` }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@api/formance.com/v1beta1/otelexporterendpoint_types.go` around lines 23 - 27, Add validation markers to OtelAuthConfig.FromSecret so secret names cannot be empty and must match Kubernetes DNS-1123 naming; for example add kubebuilder markers like +kubebuilder:validation:MinLength=1 and +kubebuilder:validation:Pattern="^[a-z0-9]([-a-z0-9]*[a-z0-9])?$" (and optionally +kubebuilder:validation:MaxLength=253) on the FromSecret field; if you need strict enforcement only when OtelAuthConfig.Type == "bearer", implement a validating webhook (referencing the OtelAuthConfig.Type and FromSecret fields) to reject objects where Type is "bearer" and FromSecret is empty/invalid.internal/resources/otelexporterendpoints/collector_config.go (1)
202-215: ⚡ Quick winRefactor redundant
nopexporter additions.The
"nop"exporter is added to theexportersmap up to three times (lines 203, 209, 213). While map overwrites are safe, this is redundant and reduces clarity.♻️ Proposed refactoring
+ needsNop := len(tracesPipelines) == 0 || len(metricsPipelines) == 0 + if needsNop { + exporters["nop"] = struct{}{} + } + - if len(tracesPipelines) == 0 && len(metricsPipelines) == 0 { - exporters["nop"] = struct{}{} + if len(tracesPipelines) == 0 { tracesPipelines = []pipelineContribution{{exporter: "nop"}} - metricsPipelines = []pipelineContribution{{exporter: "nop"}} } - if len(tracesPipelines) == 0 { - exporters["nop"] = struct{}{} - tracesPipelines = []pipelineContribution{{exporter: "nop"}} - } - if len(metricsPipelines) == 0 { - exporters["nop"] = struct{}{} + if len(metricsPipelines) == 0 { metricsPipelines = []pipelineContribution{{exporter: "nop"}} }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@internal/resources/otelexporterendpoints/collector_config.go` around lines 202 - 215, The code redundantly inserts the "nop" key into the exporters map multiple times; consolidate this by checking whether either tracesPipelines or metricsPipelines is empty and adding exporters["nop"] = struct{}{} only once before assigning default pipelineContribution values to tracesPipelines and/or metricsPipelines; update the block handling tracesPipelines, metricsPipelines and exporters (refer to symbols tracesPipelines, metricsPipelines, exporters and type pipelineContribution) so that the "nop" exporter is added a single time when any default pipeline is needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/09-Configuration` reference/02-Custom Resource Definitions.md:
- Around line 2235-2236: The document has broken anchor links for
OtelSignalConfig referenced from the `traces` and `metrics` table entries; add a
corresponding heading "##### OtelSignalConfig" (or rename an existing matching
section) so the fragment `#otelsignalconfig` exists, and ensure the heading text
exactly matches the anchor target used by the table (case/spacing) so the links
from `traces` and `metrics` resolve correctly; update either the table links or
the heading name to match each other.
---
Nitpick comments:
In `@api/formance.com/v1beta1/otelexporterendpoint_types.go`:
- Around line 29-34: Add URL/hostname validation for the
OtelSignalConfig.Endpoint field so invalid endpoints are caught at CRD
validation time: update the OtelSignalConfig struct (type OtelSignalConfig) and
add a kubebuilder validation marker above the Endpoint field (for example a
+kubebuilder:validation:Pattern comment or +kubebuilder:validation:Format) that
matches allowed schemes (http://, https://, grpc://) and bare hostnames; ensure
the json tag remains `json:"endpoint"` and keep the Auth field unchanged.
- Around line 23-27: Add validation markers to OtelAuthConfig.FromSecret so
secret names cannot be empty and must match Kubernetes DNS-1123 naming; for
example add kubebuilder markers like +kubebuilder:validation:MinLength=1 and
+kubebuilder:validation:Pattern="^[a-z0-9]([-a-z0-9]*[a-z0-9])?$" (and
optionally +kubebuilder:validation:MaxLength=253) on the FromSecret field; if
you need strict enforcement only when OtelAuthConfig.Type == "bearer", implement
a validating webhook (referencing the OtelAuthConfig.Type and FromSecret fields)
to reject objects where Type is "bearer" and FromSecret is empty/invalid.
In `@docs/09-Configuration` reference/02-Custom Resource Definitions.md:
- Line 2267: The docs entry for status.stacks is missing a description; update
the table row for `stacks` (status.stacks) to explain that it lists the matched
stack names for this endpoint and that the list is returned in a stable sorted
order so operators can interpret status without inspecting controller code
(e.g., "Lists the matched stack names for this endpoint, returned as a sorted
array of strings").
In `@internal/resources/otelexporterendpoints/collector_config.go`:
- Around line 202-215: The code redundantly inserts the "nop" key into the
exporters map multiple times; consolidate this by checking whether either
tracesPipelines or metricsPipelines is empty and adding exporters["nop"] =
struct{}{} only once before assigning default pipelineContribution values to
tracesPipelines and/or metricsPipelines; update the block handling
tracesPipelines, metricsPipelines and exporters (refer to symbols
tracesPipelines, metricsPipelines, exporters and type pipelineContribution) so
that the "nop" exporter is added a single time when any default pipeline is
needed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b6d84291-4282-4091-82a2-6514531e199c
⛔ Files ignored due to path filters (10)
config/crd/bases/formance.com_otelexporterendpoints.yamlis excluded by!**/*.yamlconfig/crd/kustomization.yamlis excluded by!**/*.yamlconfig/rbac/role.yamlis excluded by!**/*.yamlconfig/samples/formance.com_v1beta1_otelexporterendpoint.yamlis excluded by!**/*.yamldocs/09-Configuration reference/settings.catalog.jsonis excluded by!**/*.jsonhelm/crds/templates/crds/apiextensions.k8s.io_v1_customresourcedefinition_otelexporterendpoints.formance.com.yamlis excluded by!**/*.yamlhelm/operator/templates/deployment.yamlis excluded by!**/*.yamlhelm/operator/templates/gen/rbac.authorization.k8s.io_v1_clusterrole_formance-manager-role.yamlis excluded by!**/gen/**,!**/*.yaml,!**/gen/**helm/operator/templates/otelexporterendpoint-support.yamlis excluded by!**/*.yamlhelm/operator/values.yamlis excluded by!**/*.yaml
📒 Files selected for processing (11)
api/formance.com/v1beta1/otelexporterendpoint_types.goapi/formance.com/v1beta1/zz_generated.deepcopy.gocmd/main.godocs/09-Configuration reference/02-Custom Resource Definitions.mdinternal/core/platform.gointernal/resources/all.gointernal/resources/otelexporterendpoints/collector_config.gointernal/resources/otelexporterendpoints/collector_config_test.gointernal/resources/otelexporterendpoints/init.gointernal/resources/settings/opentelemetry.gointernal/tests/otelexporterendpoint_controller_test.go
flemzord
left a comment
flemzord
left a comment
There was a problem hiding this comment.
Inline review comments focused on production-readiness risks, ownership/cleanup semantics, cross-controller reconciliation, validation gaps, and failure modes.
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/core/platform.go`:
- Line 4: The DefaultCollectorImage value is pinned to an older OpenTelemetry
Collector image; update the constant DefaultCollectorImage to use the latest
stable tag (e.g., change "otel/opentelemetry-collector-contrib:0.151.0" to
"otel/opentelemetry-collector-contrib:0.153.0" or a newer stable release), run
an image vulnerability scan on the new image and commit any resulting fixes, and
update any related documentation or deployment manifests that reference
DefaultCollectorImage to match the new tag.
In `@internal/resources/otelexporterendpoints/init.go`:
- Around line 108-116: The loop drops orphaned stacks from
endpoint.Status.Stacks even when cleanupStackCollector(ctx, prev) fails;
instead, build a new list preserving any prev that either is still targeted
(targetedStacks[prev]) or whose cleanup failed, and only remove prev from the
status when cleanupStackCollector succeeds; update endpoint.Status.Stacks to
that new list (use the existing variables cleanupStackCollector, targetedStacks,
stackNames, and endpoint.Status.Stacks) so failed cleanups remain in the status
for retry while successful cleanups are removed.
In `@internal/resources/settings/opentelemetry.go`:
- Around line 56-72: The getCollectorInfo function currently trusts any Service
named by collectorServiceName; modify it to ignore Services not managed by our
controller by checking the same management annotation used in
otelexporterendpoints (e.g., look for svc.Annotations["formance.com/managed-by"]
== "otelexporterendpoint") and treat Services without that annotation (or with a
different value) as not found (return nil, nil) so they don't affect DSN
fallback or telemetry; update getCollectorInfo to perform this annotation check
before setting hasTraces/hasMetrics and constructing the endpoint.
In `@internal/tests/otelexporterendpoint_controller_test.go`:
- Around line 121-144: The test currently only waits for the Deployment to exist
before deleting the endpoint, so the subsequent ShouldNot(Succeed()) checks for
Service and ConfigMap can pass if those resources were never created; update the
It block to assert the Service ("otel-collector") and ConfigMap
("otel-collector-config") exist before the delete step by adding Eventually(...)
assertions that call LoadResource(stack.Name, "otel-collector",
&corev1.Service{}) and LoadResource(stack.Name, "otel-collector-config",
&corev1.ConfigMap{}) and assert Should(Succeed()) (similar to the existing
Deployment check) so cleanup verification is meaningful.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 29ac74d2-9563-4812-b64a-455492e5a406
⛔ Files ignored due to path filters (3)
config/crd/bases/formance.com_otelexporterendpoints.yamlis excluded by!**/*.yamldocs/09-Configuration reference/settings.catalog.jsonis excluded by!**/*.jsonhelm/crds/templates/crds/apiextensions.k8s.io_v1_customresourcedefinition_otelexporterendpoints.formance.com.yamlis excluded by!**/*.yaml
📒 Files selected for processing (8)
api/formance.com/v1beta1/otelexporterendpoint_types.gocmd/main.gointernal/core/platform.gointernal/resources/otelexporterendpoints/collector_config.gointernal/resources/otelexporterendpoints/collector_config_test.gointernal/resources/otelexporterendpoints/init.gointernal/resources/settings/opentelemetry.gointernal/tests/otelexporterendpoint_controller_test.go
🚧 Files skipped from review as they are similar to previous changes (3)
- api/formance.com/v1beta1/otelexporterendpoint_types.go
- cmd/main.go
- internal/resources/otelexporterendpoints/collector_config.go
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
5e95dda to
bb59f12
Compare
flemzord
left a comment
flemzord
left a comment
There was a problem hiding this comment.
Second deep review pass after the latest updates. I focused on production readiness and remaining behavioral risks.
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
bb59f12 to
aa00b58
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
docs/09-Configuration reference/02-Custom Resource Definitions.md (1)
2235-2236:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winFix broken
OtelSignalConfiganchor links.Both links target
#otelsignalconfig, but that anchor is not defined in the document, so navigation and markdownlint MD051 fail. Add a##### OtelSignalConfigsection (or point these links to an existing valid anchor).Suggested minimal doc fix
+##### OtelSignalConfig + +OtelSignalConfig configures a single signal type (traces or metrics). + +| Field | Description | Default | Validation | +| --- | --- | --- | --- | +| `endpoint` _string_ | Endpoint URL for the signal. Protocol is inferred from scheme (`grpc://`, `http://`, `https://`). | | | +| `auth` _[OtelAuthConfig](`#otelauthconfig`)_ | Optional per-signal authentication configuration. | | |🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/09-Configuration` reference/02-Custom Resource Definitions.md around lines 2235 - 2236, The markdown links for `OtelSignalConfig` used in the `traces` and `metrics` table rows point to a non-existent `#otelsignalconfig` anchor; add a matching heading (e.g., insert a "##### OtelSignalConfig" section with the OtelSignalConfig definition) or update the two links to an existing valid anchor so the `traces` and `metrics` table entries resolve correctly and satisfy markdownlint MD051.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@internal/tests/otelexporterendpoint_controller_test.go`:
- Around line 118-120: AfterEach currently only deletes the stack
(Delete(stack)), which can leave the endpoint resource leaking if a test fails
before it's created; update the AfterEach to unconditionally attempt cleanup of
the endpoint as well (call Delete(endpoint) or an unconditional cleanup helper)
in addition to Delete(stack), and ensure the cleanup ignores not-found errors so
it always runs without causing further test failures; locate the AfterEach block
and add the unconditional endpoint cleanup referencing the endpoint variable and
the existing Delete(stack) call.
---
Duplicate comments:
In `@docs/09-Configuration` reference/02-Custom Resource Definitions.md:
- Around line 2235-2236: The markdown links for `OtelSignalConfig` used in the
`traces` and `metrics` table rows point to a non-existent `#otelsignalconfig`
anchor; add a matching heading (e.g., insert a "##### OtelSignalConfig" section
with the OtelSignalConfig definition) or update the two links to an existing
valid anchor so the `traces` and `metrics` table entries resolve correctly and
satisfy markdownlint MD051.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a4d3cd01-c7e3-487b-b8a9-4d547a8eac79
⛔ Files ignored due to path filters (3)
config/crd/bases/formance.com_otelexporterendpoints.yamlis excluded by!**/*.yamldocs/09-Configuration reference/settings.catalog.jsonis excluded by!**/*.jsonhelm/crds/templates/crds/apiextensions.k8s.io_v1_customresourcedefinition_otelexporterendpoints.formance.com.yamlis excluded by!**/*.yaml
📒 Files selected for processing (9)
api/formance.com/v1beta1/otelexporterendpoint_types.gocmd/main.godocs/09-Configuration reference/02-Custom Resource Definitions.mdinternal/core/platform.gointernal/resources/otelexporterendpoints/collector_config.gointernal/resources/otelexporterendpoints/collector_config_test.gointernal/resources/otelexporterendpoints/init.gointernal/resources/settings/opentelemetry.gointernal/tests/otelexporterendpoint_controller_test.go
🚧 Files skipped from review as they are similar to previous changes (6)
- cmd/main.go
- internal/core/platform.go
- api/formance.com/v1beta1/otelexporterendpoint_types.go
- internal/resources/otelexporterendpoints/collector_config_test.go
- internal/resources/otelexporterendpoints/collector_config.go
- internal/resources/otelexporterendpoints/init.go
sofiasimdianova
force-pushed
the
feat/otelexportercrd-support
branch
from
aa00b58 to
b369969
Compare
flemzord
left a comment
flemzord
left a comment
There was a problem hiding this comment.
Follow-up review after the latest force-push. I resolved obsolete threads and opened focused comments for the remaining current risks.
| if err != nil { | ||
| return fmt.Errorf("creating ResourceReference for secret %q in stack %q: %w", ref.SecretName, stack.Name, err) | ||
| } | ||
| if !rr.Status.Ready { |
There was a problem hiding this comment.
The pre-existing Secret path is fine, but this fallback path can still stall. When the Secret is missing, this creates a ResourceReference and returns NewPendingError(). I do not see an OtelExporterEndpoint watch on the created ResourceReference or on the replicated Secret, and application errors do not requeue automatically here. Once the RR controller marks this RR Ready, the endpoint may not reconcile again until an unrelated Stack/Settings/endpoint event happens. Please add a watch/requeue for these RR/Secret updates and cover the fallback with an envtest that starts from a source Secret labelled formance.com/stack=any.
| b.Watches(&v1beta1.Settings{}, handler.EnqueueRequestsFromMapFunc( | ||
| func(_ context.Context, obj client.Object) []reconcile.Request { | ||
| s := obj.(*v1beta1.Settings) | ||
| if !strings.HasPrefix(s.Spec.Key, "opentelemetry.") { |
There was a problem hiding this comment.
This predicate fixes the previous global fan-out, but it drops valid wildcard Settings keys. The Settings resolver accepts wildcards per segment, so keys like *.traces.dsn, opentelemetry.*.dsn, or *.metrics.resource-attributes can affect the OTEL values read by this controller without starting with opentelemetry.. Please match the supported OTEL key patterns using the same segment/wildcard semantics instead of a string prefix.
| type OtelSignalConfig struct { | ||
| // Endpoint URL for the signal (e.g., "http://my-collector:4318", "grpc://my-collector:4317"). | ||
| // Protocol is inferred from the URL scheme. HTTP/protobuf is the default for firewall compatibility. | ||
| // +kubebuilder:validation:MinLength=1 |
There was a problem hiding this comment.
MinLength still allows unsupported or ambiguous endpoint schemes. The config builder treats only grpc:// as gRPC and sends everything else through the HTTP exporter, so values like ftp://collector, typos, or bare host:port can be accepted at admission and fail later in the collector. Please validate allowed schemes (http, https, grpc) or explicitly normalize/document bare host:port before generating the collector config.
| podAnnotations["secret-hash"] = secretHashes | ||
| } | ||
|
|
||
| replicas := int32(1) |
There was a problem hiding this comment.
The added resources/probes/securityContext are a useful improvement, but the collector runtime policy is still hard-coded here: one replica, fixed requests/limits, fixed probes/securityContext, and no scheduling/PDB/serviceAccount/imagePullSecret knobs. If this is intentionally phase-one behavior, please document that limitation clearly; otherwise expose a collector policy through Helm/platform settings before relying on this in production.
|
|
||
| condition := v1beta1.NewCondition("CollectorsReady", endpoint.GetGeneration()) | ||
| if len(pendingStacks) > 0 { | ||
| condition.Fail(fmt.Sprintf("waiting for collectors in: %s", strings.Join(pendingStacks, ", "))) |
There was a problem hiding this comment.
This condition now waits for Deployment availability, which is good, but the message remains hard to act on when the collector fails to start. For config errors, image pull failures, CrashLoopBackOff, or failed health checks, users will only see the stack name here and need to inspect Pods manually. Consider surfacing the relevant Deployment condition or latest Pod waiting reason in status.info/the condition message.
| | Field | Description | Default | Validation | | ||
| | --- | --- | --- | --- | | ||
| | `stackSelector` _[LabelSelector](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.27/#labelselector-v1-meta)_ | StackSelector is a standard Kubernetes LabelSelector (matchLabels/matchExpressions).<br />One CRD can target all current and future stacks with a single selector.<br />Matches the pattern established by Settings. | | | | ||
| | `traces` _[OtelSignalConfig](#otelsignalconfig)_ | Traces configures the traces signal. At least one of traces or metrics must be set.<br />Logs are intentionally out of scope. | | | |
There was a problem hiding this comment.
These links still point to #otelsignalconfig, but the generated document does not define an OtelSignalConfig section. status.stacks is now documented, so that part is fixed; this remaining doc issue is specifically the missing OtelSignalConfig/OtelAuthConfig generated sections or broken anchors.
| // Type is the authentication type. | ||
| // +kubebuilder:validation:Enum=bearer | ||
| Type string `json:"type"` | ||
| // FromSecret references a Secret name (expected key is "token"). |
There was a problem hiding this comment.
You should not hardcode the key and should add a FromSecretKey property.
4 participants
No description provided.