Skip to content

fix(asset_scaling): match base asset exactly, not as a string prefix #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfyrag wants to merge 1 commit into
base: test/asset-scaling-prefix-match-bug
Choose a base branch
from
Open

fix(asset_scaling): match base asset exactly, not as a string prefix #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions internal/interpreter/asset_scaling.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,18 @@ func getAssetScale(asset string) (string, int64) {
return asset, 0
}

// getAssets returns, for every precision scale found in `balance`, the amount
// available for `baseAsset`. Match is exact on the base name: `USDT` and
// `USD_RED` are NOT considered scaled forms of `USD`. Only the bare base name
// and its `baseAsset/N` precision variants qualify.
func getAssets(balance AccountBalance, baseAsset string) map[int64]*big.Int {
result := make(map[int64]*big.Int)
for asset, amount := range balance {
if strings.HasPrefix(asset, baseAsset) {
_, scale := getAssetScale(asset)
result[scale] = amount
if asset != baseAsset && !strings.HasPrefix(asset, baseAsset+"/") {
continue
}
_, scale := getAssetScale(asset)
result[scale] = amount
}
return result
}
Expand Down