Repository navigation
feat(ads): Google Ads recommendations and optimization score - #29
Merged
Merged
Conversation
Four calls on ads()->google(): recommendations, optimizationScore, and applyRecommendations and dismissRecommendations, which need publish. Adds a float coercion to Model, which the scores and conversion counts need and which no model had called for before.
tests/AdsTikTokTest.php line 35 is 168 characters against a 140 limit, which has had CI red on main since the TikTok ads merge. Not this branch's change, but this branch cannot go green without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the four Google Ads recommendation calls: the recommendation list, the optimization score, apply and dismiss.
Applying changes what the live account serves or bids, so both writes need the
publishscope on top ofads, and each id has to name a recommendation on the customer passed.Paired with fopost/fopost#1017, which adds the routes.