feat(ads): add the fopost ads google commands - #17
Merged
Merged
Conversation
Reads the Search surface no other network has: keywords and keyword ideas, search terms, assets with where each one is attached, Performance Max asset groups, conversion actions, and a raw GAQL query. The other ads commands stay network-agnostic. Pinned to the fopost-go commit that carries GoogleAdsService; re-bump to the tagged release once fopost-go ships.
# Conflicts: # go.mod # go.sum # internal/cmd/ads.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fopost ads googlereads the Search surface no other network has: keywords, keyword ideas, search terms, assets with where each one is attached, Performance Max asset groups, conversion actions, and a raw GAQLquery.The other
fopost adscommands stay network-agnostic and dispatch by connection.Merged with main (23 commits, including the catalogs and ad-library commands). The conflicts were the
adssubcommand list and its one-line summary — all three groups are registered now.Merge order: this is pinned to the
fopost-gocommit on fopost/fopost-go#22, so it builds today but wants a re-bump to the tag once that SDK is released. Needs fopost/fopost#997 on the API side. Build, vet and tests are clean.