Fix out-of-bounds read in dynamic_programming_bellman_word_ram - #1
Merged
Merged
Conversation
The final scan for the optimal value used 'optimal_value == 0' as its only stopping condition. Weight 0 is always reachable, so when it is the optimal value (no item, or no item fitting in the capacity), the scan went past word 0 and read 'output.values[-1]'. Stop the scan at word 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final scan for the optimal value in
dynamic_programming_bellman_word_ramusedoptimal_value == 0as its only stopping condition. Weight 0 is always reachable, so when it is the optimal value (no item, or no item fitting in the capacity), the scan went past word 0 and readoutput.values[-1].This stops the scan at word 0, and adds a test covering an instance with no item and an instance whose only item is heavier than the capacity.