perf(translator): increase performance#278
Merged
Merged
Conversation
This commit reduces memory allocations as possible and introduces the following changes: - Stored `Engine` in the structure `Translator` reducing the contruction and discarding of the rhai runtime on every translate call. - Eliminated `Predicate` construction before condition is checked. - Fixed a bug in the building of the `remaining_code`. - Fixed potential panic in the comparaison between the first characters. - Replaced `sort_by` by `sort_unstable_by` to reduce memory usage.
0966727 to
14b2be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Changes
Enginein the structureTranslatorreducing the construction and discarding of the rhai runtime on every translate call.Predicateconstruction before condition is checked.remaining_code.sort_bybysort_unstable_byto reduce memory usage.Additional changes
Fixed potential panic in the comparison between the first characters.
Dataset
Error