Add a way to disable admin profiler#1323
Conversation
This change adds a way to disable the admin profiler when the admin server is enabled.
rdallman
left a comment
There was a problem hiding this comment.
this seems like a really weird concern? are there issues with having admin authentication guarding these endpoints to begin with? - that seems like the real issue, no admin should reasonably be worried about this?
|
Hey @rdallman thanks for your comment, this is not a big deal i am happy to abandon this change if we think there is no value, the reason because I am proposing this is that we can have some FN implementations where different profiling mechanism are plugged into the system and therefore the net/http/pprof won't be necessary and ppl want a way to switch it off. |
|
working on this thing I noticed that we don't call the wrapper for injecting middleware in the Admin API, I opened a PR for this #1327 |
|
Ok I close this ticket in favor of #1327 |
This change adds a way to disable the admin profiler when the admin
server is enabled.
I added a new env variable that can be used to disable the admin profiler
To verify it you can: