Repository navigation
test(compiler): the shifted-parameter test no longer depends on row order - #1893
Merged
Merged
Conversation
…rder The frame the bare shift leaves was collected unsorted, so its row order varied and the test failed about one run in five. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018pGzyDMmp1WD4B65wFR8op
Merging this PR will not alter performance
Comparing 
Footnotes
|
FBumann
pushed a commit
that referenced
this pull request
Oct 8, 2026
Main holds the stack below as squash commits: its tree is #1884's last head, merged in the commit before this one, plus #1893's test fix, taken here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014wLrXpeSGDqoBFxyrs8NEz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
test_a_zero_edge_writes_its_rows_like_any_other_fillcollected the bare shift's frame unsorted, so its row order varied and it failed 8 of 40 runs onmain. It now sorts bysnapshot, as the same test's first frame does: 0 of 40.Method and gates
origin/main):pixi run pytest -q -p no:randomly tests/test_compiler.py -k zero_edge_writes, 40 runs, 8 failed.pixi run check: 5030 passed, 564 skipped, 1 xfailed;ruff, format andpyreflyclean.testtype, so no changelog line.collect()calls in the tests. This one showed up as a red run on refactor(api): keep= is gone, and a re-solve carries on from where the last solve ended unless start=None says otherwise #1884.🤖 Generated with Claude Code
https://claude.ai/code/session_018pGzyDMmp1WD4B65wFR8op