Skip to content

feat(language): a special-ordered set names its dimension with along, the way math-spec 0.0.0-alpha.120 does - #1720

Merged
FBumann merged 1 commit into
mainfrom
claude/ecstatic-gauss-rj1qiy
Sep 23, 2026
Merged

FBumann merged 1 commit into
mainfrom
claude/ecstatic-gauss-rj1qiy

Conversation

@FBumann

@FBumann FBumann commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Prompt: upate lpspec to the latest mathspec version

Note

The following content was generated by AI.

The pin moves from math-spec 0.0.0-alpha.119 to 0.0.0-alpha.120, the latest tag. An sos: block now says along: where it used to say over:. A model that still says over: is refused at load, so this is a feat and not a build.

What changed, what was verified, what was not

The break. energy-models/mathspec#646 renames SosBlock.over and SosDeclaration.over to along. lpspec used the field in two places, and both now read .along:

  • src/lpspec/linopy/builder.py: sos_dim=
  • src/lpspec/relational/engines/polars/assembly.py: _build_sos

The tree follows. examples/piecewise_conversion.yaml and its page docs/examples/piecewise_conversion.md now say along: bp in their sos: block. piecewise: blocks keep over: because math-spec did not rename that key. The tests in test_sos.py, test_check_sink.py and test_piecewise.py now spell the key along. The refusal in test_sos.py now quotes math-spec's new message (along 'other' is not a dim…). No test was removed, so no coverage moved.

The lock. I regenerated uv.lock with uv lock, which resolves to 086ff9a.

Gates. pixi could not be installed in this session because the proxy refused pixi.sh. I ran the check task's gates through uv against the locked environment instead:

  • ruff check . passed.
  • ruff format --check . passed.
  • pyrefly check passed on both configs.
  • pytest -n auto gave 3797 passed and 10 failed. All 10 failures are [gurobi]/[xpress] cases in test_diagnostics.py and test_relational.py. They fail the same way on the base commit, because neither solver is installed here.

I did not run test-bench, because bench/ is untouched.

🤖 Generated with Claude Code

https://claude.ai/code/session_014PPGQSYbTiSuwDiAcpEGxF


Generated by Claude Code

… the way math-spec 0.0.0-alpha.120 does

The pin moves to math-spec 0.0.0-alpha.120, whose sos block takes
`along:` in place of `over:`. Both lanes read `SosDeclaration.along`, and
the example, its page and the tests say `along:`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014PPGQSYbTiSuwDiAcpEGxF
@codspeed

codspeed Bot commented Sep 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 24 untouched benchmarks
⏩ 58 skipped benchmarks1


Comparing claude/ecstatic-gauss-rj1qiy (a56f79b) with main (813aeb3)2

Open in CodSpeed

Footnotes

  1. 58 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (9e0c472) during the generation of this report, so 813aeb3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@read-the-docs-community

Copy link
Copy Markdown

Documentation build overview

📚 lpspec | 🛠️ Build #34722027 | 📁 Comparing a56f79b against latest (9e0c472)

  🔍 Preview build  

1 file changed
± examples/piecewise_conversion/index.html

@FBumann
FBumann merged commit fdc47c5 into main Sep 23, 2026
12 checks passed
@FBumann
FBumann deleted the claude/ecstatic-gauss-rj1qiy branch September 23, 2026 16:14
fluxopt-release-bot Bot added a commit that referenced this pull request Sep 23, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.0.1-alpha.351](v0.0.1-alpha.350...v0.0.1-alpha.351)
(2026-09-23)


### Features

* **language:** a special-ordered set names its dimension with along,
the way math-spec 0.0.0-alpha.120 does
([#1720](#1720))
([fdc47c5](fdc47c5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: fluxopt-release-bot[bot] <307443024+fluxopt-release-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants