Repository navigation
build(deps): math-spec 0.0.0-alpha.92, which says the dimensions a walk joins on - #1663
Merged
Merged
Conversation
…lk joins on The pin follows the release that carries GroupSum.joined and At.joined, and the two copies of that answer here — relations.joined_dims on the relational lane and builder._joined_dims on the eager one — read it off the node instead. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DT1r52zPp9BdnrzFdp1xoY
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
The pin follows math-spec 0.0.0-alpha.92, the release carrying energy-models/mathspec#488:
GroupSum.joinedandAt.joined. The two copies of that answer here —relations.joined_dimson the relational lane andbuilder._joined_dimson the eager one — are deleted, and both lanes read it off the node. The follow-up #1659 and #1660 named.What moved
pyproject.tomlanduv.lock: the pin,v0.0.0-alpha.89tov0.0.0-alpha.92.relations.py:landedandwalk_jointake the node rather than its walks, and readnode.joined;joined_dimsis gone.compiler.py:_remap_fragmenttakes the node;_empty_groupsand_pulled_back_presencesreadg.joinedanda.joined.linopy/builder.py: the grouped sum passesnode.joined;_joined_dimsis gone.Five files, +26 −40.
Verified
ruff check·ruff format --check·pyrefly check·pytest -q -n 4on 309422e, with alpha.92 installed: 3772 passed, the same 10 failures asmain(gurobi,xpressnot installed here). Run in auvvenv with thelinopyextra rather than pixi.Not run:
docs-buildandtest-floors, no pixi environment here. The parity job checks out the corpus at the pinned tag, so it runs against alpha.92 in CI.🤖 Generated with Claude Code
https://claude.ai/code/session_01DT1r52zPp9BdnrzFdp1xoY
Generated by Claude Code