build(deps): follow the language to alpha.48 - #1456
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
… stops answering it Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
FBumann
force-pushed
the
build/math-spec-alpha47
branch
from
August 31, 2026 07:59
652fb5a to
ef13af8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
math-spec
v0.0.0-alpha.46→v0.0.0-alpha.48, and the engine stops answeringa question about the language.
predicate_dimsis deleted — 37 lines walking the closedWhereNodeunionto say which dims a mask reads. Its own docstring said what owning it cost:
That is a rule about the language stated in a consumer, and math-spec was
already answering it a second time in
_check_where_dims. #269 gave it onehome as
where_parser.dims_read, with the load-time frame check as a reader ofit. Both call sites here —
PolarsCompiler.frame's semi-join andlabels._free_prefix— now ask the language.The deletion also drops a branch the language never had:
predicate_dimstreated a
strright-hand side as possibly a parameter name, butParameterComparisonNode.valueis a literal and astrthere is a flag. Amodel comparing a
strparameter to a flag whose text collided with a declaredname would union that name's dims in. It widened the set rather than narrowing
it, so it cost a join-strategy fallback rather than an answer — but it was a
reading nothing licensed.
alpha.47 was docs-only (
git diff v0.0.0-alpha.46 v0.0.0-alpha.47 -- src/is empty), so it carries nothing of its own and this goes straight to .48.
⚠ CI is red until the release lands
v0.0.0-alpha.48does not exist yet —math-spec#270 is the
release-please PR that cuts it. Until that merges the pin cannot resolve and
every job here fails at install. Nothing in this branch is waiting on
review; merging #270 and re-running is the whole of it.
Verified locally against the merged upstream instead, with
origin/mainat350b1ed(#269) onPYTHONPATHand this branch's codeunchanged:
ruff check/format,pyreflyoversrc/(0 errors),pixi run pytest bench/test_harness.py(112 passed), and the full suite at94 failed / 3434 passed — the failure set is
main's on this machine, allxpress, all the expired local licence, and the passing count is identicaleither side of the deletion.
The sweep this came out of, and what stays
Everything else lpspec still owns was put to "would two consumers answering it
separately be a bug?", and the rest survives:
_certain_parameters— which names' absence alone falsifies a mask.Reads like a language rule and is not: its own docstring records that the two
strategies differ only in where a row is dropped, so it is a join
optimisation whose answer changes no model.
linopy/absence.py— rule 8 on the eager lane. Both lanes implement itbecause both execute; that is two implementations of one rule by design,
held by the differential suite.
errors._SPELLED— sink-capability vocabulary, which is per sink and socannot be the language's.
sources.py's ordering and one-row-per-coordinate rules, stated indocstrings. These are the language's, and
math-spec#242 is the PR
that takes them — unreleased, and its stack is nine releases behind
main, sothere is nothing to follow yet.
No mutation table: no correctness guard changes. The runtime
LanguageErrorfencepredicate_dimscarried is not replaced but upgraded —dims_read'sassert_nevermakes an unhandled predicate node a type error atthe commit that adds it, rather than a raise at the first model to use one.