Repository navigation
fix: the solve page finds a scenario's sources in archives that specsolve 0.8 and later write - #10
Merged
Merged
Conversation
…olve 0.8 and later write Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAz2z9GVsHSQypiTUZyrY9
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AAz2z9GVsHSQypiTUZyrY9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The following content was generated by AI.
The Solve page (#9) named a scenario's sources from the archive's
sources.parquet. fluxopt/specsolve#1913 removed that file, so every live scenario failed with a 404. The page now takes thesources/<name>.parquetpaths from the archive'scatalog.parquet.Cause, fix, and what was verified
Cause. #9 was tested against archives written with specsolve 0.6.2, which still wrote
sources.parquet. The showcase writes with 0.8.1 since fluxopt/specsolve-showcase#18. In 0.8.1 an archive no longer digests its sources (fluxopt/specsolve#1913), so the file is gone. #9's description said the local archives were "as the live ones are". That was wrong.Fix.
loadQuestioninsrc/solver.tsreads thepathcolumn of the archive's owncatalog.parquet, and keeps the paths undersources/. A catalog lists every source, dimensions included, in both layouts.Verified, in headless Chromium with specsolve 0.9.0 from PyPI. The archives were the showcase's four scenarios, solved at its
main(de8a389) with specsolve 0.8.1 and published with itstools.publish_archive, so they are in the live layout:mainat5570c73shows the same…/runs/base/sources.parquet answered 404.invest× 0.6 matches the published cheap_solar costs.dtype: integershows specsolve'sSchemaError.base-edited.zip. specsolve 0.9.0 reads it, and its objectives equal the published cheap_solar ones exactly.npm run buildpasses.Not tested: the live jsDelivr CDN and
fluxopt.github.ioare not reachable from here.🤖 Generated with Claude Code
https://claude.ai/code/session_01AAz2z9GVsHSQypiTUZyrY9
Generated by Claude Code