Skip to content

Add swipedown exit fullscreen feature - #930

Merged
diegotori merged 4 commits into
fluttercommunity:masterfrom
Fullphysio:feat/swipe-down-exit-fullscreen
Sep 14, 2026
Merged

diegotori merged 4 commits into
fluttercommunity:masterfrom
Fullphysio:feat/swipe-down-exit-fullscreen

Conversation

@Ortes

@Ortes Ortes commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 19, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.68%. Comparing base (a34f816) to head (e776ce7).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
+ Coverage   70.86%   71.68%   +0.82%     
==========================================
  Files          40       40              
  Lines        2440     2518      +78     
==========================================
+ Hits         1729     1805      +76     
- Misses        711      713       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegotori

Copy link
Copy Markdown
Collaborator

Two things:

  1. You need to make this configurable from the ChewieConttoller. In other words, you need to make this opt-in.
  2. When making this configurable, you also need to make the threshold dismissing on swipe a configurable value, defaulting to a reasonable value.

@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch 2 times, most recently from cd41237 to 0974735 Compare September 22, 2025 10:28
Ortes added a commit to Fullphysio/chewie that referenced this pull request Aug 12, 2026
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from 0974735 to a56c7f0 Compare August 12, 2026 07:25
Ortes added a commit to Fullphysio/chewie that referenced this pull request Aug 15, 2026
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from a56c7f0 to 62076b0 Compare August 15, 2026 11:14
Ortes added a commit to Fullphysio/chewie that referenced this pull request Aug 27, 2026
Covers the fullscreen swipe gesture added in fluttercommunity#930: a downward fling above
swipeThreshold exits fullscreen, one below it and any upward fling do not,
a custom swipeThreshold shifts the cutoff, and swipeToExitFullscreen: false
leaves the gesture unwired. Also covers the two new ChewieController fields
in the constructor defaults and in copyWith.
Ortes added a commit to Fullphysio/chewie that referenced this pull request Sep 9, 2026
Ortes added a commit to Fullphysio/chewie that referenced this pull request Sep 9, 2026
Covers the fullscreen swipe gesture added in fluttercommunity#930: a downward fling above
swipeThreshold exits fullscreen, one below it and any upward fling do not,
a custom swipeThreshold shifts the cutoff, and swipeToExitFullscreen: false
leaves the gesture unwired. Also covers the two new ChewieController fields
in the constructor defaults and in copyWith.
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from 9a8696f to b77bc0d Compare September 9, 2026 09:34
Ortes added a commit to Fullphysio/chewie that referenced this pull request Sep 14, 2026
Covers the fullscreen swipe gesture added in fluttercommunity#930: a downward fling above
swipeThreshold exits fullscreen, one below it and any upward fling do not,
a custom swipeThreshold shifts the cutoff, and swipeToExitFullscreen: false
leaves the gesture unwired. Also covers the two new ChewieController fields
in the constructor defaults and in copyWith.
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from b77bc0d to dcbcc30 Compare September 14, 2026 21:05

@diegotori diegotori left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Covers the fullscreen swipe gesture added in fluttercommunity#930: a downward fling above
swipeThreshold exits fullscreen, one below it and any upward fling do not,
a custom swipeThreshold shifts the cutoff, and swipeToExitFullscreen: false
leaves the gesture unwired. Also covers the two new ChewieController fields
in the constructor defaults and in copyWith.
@Ortes
Ortes force-pushed the feat/swipe-down-exit-fullscreen branch from dcbcc30 to e776ce7 Compare September 14, 2026 21:24

@diegotori diegotori left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diegotori
diegotori merged commit a2052b6 into fluttercommunity:master Sep 14, 2026
5 checks passed
diegotori added a commit that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants