fix(tool): update self-check for explicit secret passthrough - #21
Merged
Conversation
…re/security-hardening
…ssthrough The security hardening replaced 'secrets: inherit' with explicit PRECOMPILE_BINARIES_PRIVATE_KEY passthrough. Update the self-check to match.
There was a problem hiding this comment.
Pull request overview
Updates the Darwin package self-check script to reflect the CI change from secrets: inherit to explicit secret passthrough for the reusable precompile-binaries workflow call (follow-up to PR #20’s security hardening).
Changes:
- Replaces the
secrets: inheritinvariant check with a check for explicitPRECOMPILE_BINARIES_PRIVATE_KEYpassthrough inpublish-pub.yml.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| " uses: ./.github/workflows/precompile-binaries.yml" | ||
| require_exact_line ".github/workflows/publish-pub.yml" " contents: write" | ||
| require_exact_line ".github/workflows/publish-pub.yml" " secrets: inherit" | ||
| require_contains ".github/workflows/publish-pub.yml" "PRECOMPILE_BINARIES_PRIVATE_KEY: \${{ secrets.PRECOMPILE_BINARIES_PRIVATE_KEY }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20. Self-check updated for secrets change.