Updated fragment shader sample to use uniform-by-name accessor#2736
Open
gaaclarke wants to merge 6 commits into
Open
Updated fragment shader sample to use uniform-by-name accessor#2736gaaclarke wants to merge 6 commits into
gaaclarke wants to merge 6 commits into
Conversation
Member
Author
|
I think these things are making it to stable. Unfortunately it looks like there is a bug in vulkan implementation though (flutter/flutter#180595). So it's probably not worth sending people to this new API quite yet. |
Contributor
|
Greetings from stale PR triage! 👋 |
Member
Author
|
The feature these changes show is not 100% working on stable so we don't want to update the samples yet. They work on |
Member
Author
|
This probably compiles but fails on vulkan until 3.44 comes out. |
andywolff
approved these changes
May 14, 2026
Contributor
andywolff
left a comment
andywolff
left a comment
There was a problem hiding this comment.
LGTM, I'll send you a PR to do the same for simple_sdf
walley892
requested changes
May 14, 2026
walley892
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not land until the following are on stable:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.