Fix startNotify double-call crash during app launch#8984
Merged
Conversation
Remove process.startNotify() from the shared DaemonApi.listen() helper to prevent the IntelliJ platform framework from double-starting the process in run/debug configurations, which throws a "startNotify called already" exception in platform versions 2025.3+. We explicitly add it back manually in DeviceDaemon.java since that background daemon is managed manually by the plugin and still requires a manual boot signal. TAG=agy CONV=fccd665d-3066-4b89-92ff-553454d58b2f
5a17d80 to
f12c3cf
Compare
jwren
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run app was causing the error (pasted below) in 2026.1 because the process calls
startNotifytwice.startNotifyhad to be added toDeviceDaemonstartup since that daemon was depending on theDaemonApiclass calling it.To test, start running (not debug) an app and make sure this error doesn't happen.