ci: bump pinned Flutter SDK to version 3.44.0#8982
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the pinned Flutter SDK version from 3.41.9 to 3.44.0 in the provisioning script. A review comment identifies a logical issue where the script only checks for the existence of the Flutter directory but does not verify if the installed version matches the pinned version, which could lead to stale environments during local development.
| # Pinned Flutter SDK version. This constant is automatically checked and updated weekly | ||
| # by the .github/workflows/update_flutter.yaml GitHub Actions workflow. | ||
| FLUTTER_VERSION="3.41.9" | ||
| FLUTTER_VERSION="3.44.0" |
There was a problem hiding this comment.
[MUST-FIX] The provisioning logic (line 10) only checks for the existence of the ../flutter directory and does not verify the version. When FLUTTER_VERSION is updated, an existing installation of an older version will not be replaced, which can lead to inconsistent environments (e.g., in local development). Consider updating the script to verify the version or to remove the existing directory if it doesn't match the pinned version.
References
- Logical bugs should be flagged as [MUST-FIX]. (link)
flutteractionsbot
force-pushed
the
auto-update-flutter-sdk
branch
from
1de5e9e to
f578c68
Compare
1 participant
An automated check has detected a new stable release of the Flutter SDK.
3.44.0This Pull Request updates our shared provisioning script (
tool/provision_flutter.sh) to target this version. All presubmit tests will be run against this version to verify compatibility.