Update for Flutter 3.47 - #2415
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates steps 03 through 08 of the animated-responsive-layout codelab, including upgrading the Dart SDK constraint, Gradle wrapper, Android Gradle Plugin, and platform deployment targets. However, a critical issue was identified across all steps: the Kotlin plugin was removed from the build.gradle.kts files while android.builtInKotlin is disabled and a kotlin configuration block is still used, which will cause Gradle build failures. Suggestions have been provided to re-add the Kotlin plugin.
| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}| plugins { | ||
| id("com.android.application") | ||
| id("kotlin-android") | ||
| // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins. | ||
| id("dev.flutter.flutter-gradle-plugin") | ||
| } |
There was a problem hiding this comment.
The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.
plugins {
id("com.android.application")
id("org.jetbrains.kotlin.android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.