Skip to content

Update for Flutter 3.47 - #2415

Open
domesticmouse wants to merge 25 commits into
flutter:mainfrom
domesticmouse:flutter-3.47
Open

Update for Flutter 3.47#2415
domesticmouse wants to merge 25 commits into
flutter:mainfrom
domesticmouse:flutter-3.47

Conversation

@domesticmouse

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates steps 03 through 08 of the animated-responsive-layout codelab, including upgrading the Dart SDK constraint, Gradle wrapper, Android Gradle Plugin, and platform deployment targets. However, a critical issue was identified across all steps: the Kotlin plugin was removed from the build.gradle.kts files while android.builtInKotlin is disabled and a kotlin configuration block is still used, which will cause Gradle build failures. Suggestions have been provided to re-add the Kotlin plugin.

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Comment on lines 1 to 5
plugins {
id("com.android.application")
id("kotlin-android")
// The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
id("dev.flutter.flutter-gradle-plugin")
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Kotlin plugin (org.jetbrains.kotlin.android) was removed from the plugins block, but android.builtInKotlin is set to false in gradle.properties. Additionally, the kotlin configuration block is used later in this file. Without applying the Kotlin plugin, Gradle will fail to evaluate the build script because the kotlin extension will not be registered, and Kotlin compilation will not be configured. Please re-add the Kotlin plugin to the plugins block.

plugins {
    id("com.android.application")
    id("org.jetbrains.kotlin.android")
    // The Flutter Gradle Plugin must be applied after the Android and Kotlin Gradle plugins.
    id("dev.flutter.flutter-gradle-plugin")
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant