Reset failed check run back to in progress if all failed jobs are re-runned - #5117
Open
ievdokdm wants to merge 3 commits into
Open
Reset failed check run back to in progress if all failed jobs are re-runned#5117ievdokdm wants to merge 3 commits into
ievdokdm wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the LUCI build service to support re-requesting check runs when re-running failed checks under the unified check run flow, updating the github package dependency to version 9.26.0 and adding corresponding tests and mocks. A review comment correctly points out that the stage != null condition is unnecessarily required for initial runs, which could prevent updating the check run status to in-progress when stage is null, and suggests restricting this check to re-runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#189943