Enabled test suppression for unified check run - #5111
Merged
auto-submit[bot] merged 3 commits intoJul 22, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request extends the test suppression check and reporting logic to unified check runs within PresubmitSubscription. It introduces an optional summaryPrepend parameter to PresubmitCompletedJob.fromBuild to prepend a suppression warning message to the build summary, and updates the corresponding unit tests. The review feedback suggests a cleaner approach to combining summaryPrepend and build.summaryMarkdown using collection if and join to prevent trailing newlines when the summary is empty.
jtmcdole
approved these changes
Jul 22, 2026
ievdokdm
added
the
autosubmit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: flutter/flutter#189877