Resolve #2288: discover factory and value event handlers#2317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discover
@OnEvent()handlers declared on singletonuseFactoryanduseValueprovider instances so event-bus discovery matches its singleton provider contract.Linked context: Closes #2288
Changes
Testing
pnpm --filter @fluojs/event-bus... buildpnpm exec biome check packages/event-bus/src/service.ts packages/event-bus/src/module.test.ts .changeset/calm-event-bus-discovery.mdpnpm --filter @fluojs/event-bus testpnpm --filter @fluojs/event-bus typecheckpnpm --filter @fluojs/event-bus buildpnpm verify:release-readinessGIT_MASTER=1 git diff --checkRelease impact
Public export documentation
See docs/contracts/public-export-tsdoc-baseline.md for the repo-wide authoring baseline.
@param/@returnstags where applicable.@exampleblocks and README scenario examples still play complementary roles.Behavioral contract
See docs/contracts/behavioral-contract-policy.md for full details.
Platform consistency governance (SSOT)
See docs/architecture/platform-consistency-design.md and docs/contracts/release-governance.md.
createPlatformConformanceHarness(...)tests.