Resolve #2287: allow nested CQRS publishes to drain#2315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow nested CQRS
publish(...)andpublishAll(...)calls from active handler/saga pipelines to continue draining after shutdown starts while continuing to reject brand-new external publishes.Linked context: Closes #2287
Changes
publishAll(...), and stale-context rejection.@fluojs/cqrs.Testing
pnpm exec biome check packages/cqrs/src/dispatch-context.ts packages/cqrs/src/buses/event-bus.ts packages/cqrs/src/buses/saga-bus.ts packages/cqrs/src/module.test.ts packages/cqrs/README.md packages/cqrs/README.ko.md docs/architecture/cqrs.md docs/architecture/cqrs.ko.md .changeset/tame-cqrs-drain.mdpnpm --filter @fluojs/cqrs... buildpnpm --filter @fluojs/cqrs typecheckpnpm --filter @fluojs/cqrs testpnpm docs:sync-checkpnpm verify:platform-consistency-governancepnpm verify:changeset-release-lanepnpm verify:release-readinesswas attempted; it failed in unrelated existing/infra-sensitive suites (packages/cron/src/optional-redis-peer.test.tstimeout andpackages/testing/src/surface.test.tstimeout/unhandled rejection while rebuilding@fluojs/diagainst missing@fluojs/coredeclarations).Release impact
Public export documentation
@param/@returnstags where applicable.@exampleblocks and README scenario examples still play complementary roles.Behavioral contract
Platform consistency governance (SSOT)
createPlatformConformanceHarness(...)tests.