feat: support tpl evaluation in podAnnotations#709
Open
elimayost wants to merge 1 commit into
Open
Conversation
elimayost
requested review from
patrick-stephens and
stevehipwell
as code owners
stevehipwell
requested changes
Apr 13, 2026
Collaborator
stevehipwell
left a comment
stevehipwell
left a comment
There was a problem hiding this comment.
@elimayost please follow the contributing guide; you need to add a changelog entry.
Collaborator
|
@elimayost you also need to sign the DCO. |
elimayost
force-pushed
the
feat/template-pod-annotations
branch
from
23d4117 to
be97764
Compare
elimayost
force-pushed
the
feat/template-pod-annotations
branch
from
be97764 to
68ccb88
Compare
Author
|
@stevehipwell How can I make this PR move forward? Apologies if it's obvious, but it is the first time I contribute. fluentd/CHANGELOG didn't exist so I created it. |
Collaborator
|
@elimayost if you rebase your PR you should be able to use the CHANGELOG I added in #720 and the automation tests should also pass. |
Signed-off-by: Eli Mayost <eli.mayost@gmail.com>
elimayost
force-pushed
the
feat/template-pod-annotations
branch
from
43894ba to
e4e35ba
Compare
Author
|
@stevehipwell Done. Hopefully correctly. Thanks for your support. |
stevehipwell
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables tpl evaluation within the podAnnotations loop of the Fluentd DaemonSet.
Why? The current toYaml implementation treats annotation values as static strings. By using tpl, users can pass dynamic template logic into annotations via values.yaml.
Use Case: This is specifically useful when using Fluentd as a subchart. It allows a parent chart to inject dynamic file-based checksums (e.g., checksum/config: '{{ include "parent.configHash" . }}'), solving the issue of triggering rolling restarts when external configurations change.
Changes: