Conversation
Winston transport already forwards sender options at runtime, but Options omitted enableReconnect so TypeScript users could not pass it. Fix fluent#159 Signed-off-by: Christopher Pruijsen <christopher.pruijsen@gmail.com>
cpruijsen
force-pushed
the
fix/issue-159
branch
from
September 11, 2026 13:57
34be645 to
219dd81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
enableReconnect?: booleanto the sharedOptionsinterface inlib/index.d.ts. The runtime flag has been a FluentSender option since #111, and the winston transport already passes constructor options through to that sender, but a config typed asOptionscould not include the flag (issue #159: "There is no such option, or types are outdated").The README documents that the winston transport accepts the same options as
createFluentSender, includingenableReconnect, and lists the flag in the Options catalog next toreconnectInterval.The other option is to restore a typed winston transport constructor that takes
Options. winston support is typed asanyon purpose so TypeScript users are not forced to depend onwinston-transport(#163).Optionsis already the config type forcreateFluentSender/configure. Can switch to a typed constructor.Test plan
npx mocha -t 10000 test/test.winston.jsenableReconnectis removed fromOptions, passes with it presentenableReconnect: falsedoes not install the reconnect error handler