Skip to content

OCP-7512 - Add AAC profiles to codec and all AAC test suites#381

Merged
rsanchez87 merged 1 commit into
masterfrom
OCP-7512
Jul 22, 2026
Merged

OCP-7512 - Add AAC profiles to codec and all AAC test suites#381
rsanchez87 merged 1 commit into
masterfrom
OCP-7512

Conversation

@rsanchez87

@rsanchez87 rsanchez87 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

More info here:

https://standards.iso.org/ittf/PubliclyAvailableStandards/ISO_IEC_14496-26_2010_Bitstreams/DVD1/mpeg4audio-conformance/doc/fileNameConventions.html

Test:


## System Information

**OS:** Linux 6.17.0-35-generic

**CPU:** AMD Ryzen 7 7745HX with Radeon Graphics

**GPU:** 00.0 VGA compatible controller: NVIDIA Corporation AD107M, 00.0 VGA compatible controller: Advanced Micro Devices, Inc. [PRIMARY]

**RAM:** 30.5 GB

**Backends:**
- VDPAU: G3DVL VDPAU Driver Shared Library version 1.0
- NVDEC: Available (NVIDIA Driver 595.71.05)

**Test Suite: MPEG4_AAC-ADTS**

|Test|Fluendo-AAC-SW|
|-|-|
|PASSED|0/9|
|FAILED\ERROR|9/9|
|TOTAL TIME|0.568s|

|Profile|Fluendo-AAC-SW|
|-|-|
|AAC_LC|0/5|
|AAC_LTP|0/4|

|Test|Fluendo-AAC-SW|
|-|-|
|al18_32|❌|
|al18_22|❌|
|ap04_48|❌|
|al18_64|❌|
|ap02_48|❌|
|al18_08|❌|
|ap01_48|❌|
|al18_96|❌|
|ap05_48|❌|

@rsanchez87
rsanchez87 marked this pull request as ready for review July 13, 2026 13:06
Comment thread fluster/codec.py
@mdimopoulos

Copy link
Copy Markdown
Contributor

My idea is to have this done programmatically, meaning that the generator script detects the "profiles" via ffmpeg for example and writes them to the jsons.
Do you think it's feasible?

@rsanchez87

rsanchez87 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

My idea is to have this done programmatically, meaning that the generator script detects the "profiles" via ffmpeg for example and writes them to the jsons. Do you think it's feasible?

You mean in the gen_aac.py, right? If yes, I'll add it, done

@mdimopoulos

Copy link
Copy Markdown
Contributor

My idea is to have this done programmatically, meaning that the generator script detects the "profiles" via ffmpeg for example and writes them to the jsons. Do you think it's feasible?

You mean in the gen_aac.py, right? If yes, I'll add it, done

yes exactly

@mdimopoulos mdimopoulos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor change requests. Other than that it runs trouble-free!

Comment thread scripts/gen_aac.py
Comment thread scripts/gen_aac.py Outdated
- Add AAC profiles to Profile enum: AAC Main, AAC LC, AAC SSR,
  AAC LTP, Error Resilient AAC LD/LC/ELD
- Add profile field to all 1432 test vectors across 6 AAC test suites
- Auto-detect profiles via ffprobe in gen_aac.py
@rsanchez87
rsanchez87 merged commit e9f65ef into master Jul 22, 2026
5 checks passed
@rsanchez87
rsanchez87 deleted the OCP-7512 branch July 22, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants