Fix bug in iter() for for mpCtrl - #46
Closed
shfischer wants to merge 1 commit into
Closed
Conversation
iagomosqueira
added a commit
that referenced
this pull request
Jul 29, 2026
Member
|
Thanks, left behind during change of iter() argument from iter to i. This was needed to avoid conflict with iterators::iter wghich showed up as R fixed a bug in S4. I have merged this manually in the devel branch, which will merge into main today. |
Member
|
Now in main 3cb7601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in the iter() method for class mpCtrl:
mse/R/mpCtrl-class.R
Lines 291 to 294 in 71b3efc
If an argument of any of the
mseCtrlmodules ofmpCtrlis anFLQuant, theniterwill fail, e.g.This is because
mse/R/mpCtrl-class.R
Line 292 in 71b3efc
passes the function
iterinstead of the actual iterationsi