fix: bind UserContextServiceInterface instead of UserContextInterface in Objects.yaml - #53
Draft
gradinarufelix wants to merge 1 commit into
Draft
Conversation
… in Objects.yaml DefaultUserContextService implements UserContextServiceInterface, which is also the interface SentryClient injects. The previous binding targeted the UserContext value-object interface and only worked through Flow's implicit single-implementation resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultUserContextServiceimplementsUserContextServiceInterface, which is also the interfaceSentryClientinjects. The previousObjects.yamlbinding targeted theUserContextvalue-object interface — whichDefaultUserContextServicedoes not implement — and only worked because Flow's implicit single-implementation resolution happened to pick the right class for the injected interface.One-line fix, no behavior change; it just makes the intended binding explicit.