fix: consume npm @flowcore/data-pump + @flowcore/sdk (drop frozen JSR copies)#92
Merged
Merged
Conversation
… copies) pathways still pulled the pre-Bun-migration JSR packages: jsr:@flowcore/data-pump@0.21.4 → jsr:@flowcore/sdk@4.2.2, whose NotificationClient has an unguarded JSON.parse that crashes the host process on a malformed frame (and wedges the pump). Both packages migrated to Bun/npm, and the SDK fix shipped as npm @flowcore/sdk@4.2.4. Switch the two imports to the npm packages: - @flowcore/data-pump: jsr:^0.21.4 → npm:^0.22.1 (0.22.0 = bun migration, no API change from 0.21.4; transitively uses npm @flowcore/sdk ^4.2.3) - @flowcore/sdk: npm:^4.2.2 → npm:^4.2.4 (the guarded NotificationClient) deno.lock now resolves both to npm; jsr:@flowcore/sdk is gone. deno check passes; suite green except tests/server.test.ts (local port 3001 conflict only). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pathways still imported the pre-Bun-migration JSR packages:
jsr:@flowcore/data-pump@0.21.4→jsr:@flowcore/sdk@4.2.2. That SDK copy'sNotificationClienthas an unguardedJSON.parse(data.message)that crashes the host process on a malformed frame and wedges the pump (observed repeatedly infishfacts-ai-backend).@flowcore/sdkand@flowcore/data-pumpboth migrated to Bun/npm; the SDK fix shipped as npm@flowcore/sdk@4.2.4. But pathways never moved off the frozen JSR copies, so the fix couldn't flow through.Change
Switch the two imports to npm:
@flowcore/data-pump:jsr:^0.21.4→npm:^0.22.1(0.22.0 is the bun migration — no API change from 0.21.4; transitively uses npm@flowcore/sdk ^4.2.3)@flowcore/sdk:npm:^4.2.2→npm:^4.2.4(the guarded NotificationClient)deno.locknow resolves both via npm;jsr:@flowcore/sdkis gone.deno checkpasses; full suite green excepttests/server.test.ts(local port-3001 conflict only — passes on CI).🤖 Generated with Claude Code