fix(daemonclient): register IMAP/POP3#1668
Open
2005czq wants to merge 1 commit into
Open
Conversation
floatpanebot
added
area/daemon
Contributor
There was a problem hiding this comment.
Pull request overview
Registers additional backend implementations (IMAP and POP3) for daemonclient’s in-process directService fallback mode so that local/direct operation supports the same protocols as the rest of the app.
Changes:
- Add blank imports for
backend/imapandbackend/pop3so theirinit()registration runs indaemonclient. - Keep the direct-mode backend registry consistent with supported protocols (IMAP/JMAP/Maildir/POP3).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Register IMAP and POP3 backends in daemonclient's directService path.
Why?
daemonclient already imports JMAP and Maildir for directService backend registration. IMAP and POP3 are supported by the app as well, but are not registered locally in daemonclient.
This keeps the direct fallback backend set consistent with the supported protocols.