Skip to content

fix(security): 2 improvements across 2 files #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(security): 2 improvements across 2 files #1651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5be0bfc
fix(security): 2 improvements across 2 files
tomaioo Jul 5, 2026
3b15355
fix(security): 2 improvements across 2 files
tomaioo Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion clib/markdown_nocgo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ func MarkdownToHTML(md []byte) []byte {
var buf bytes.Buffer
p := goldmark.New(
goldmark.WithRendererOptions(
html.WithUnsafe(),
),
)
if err := p.Convert(md, &buf); err != nil {
Expand Down
4 changes: 1 addition & 3 deletions notify/notify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package notify

import (
"fmt"
"os/exec"
"runtime"
)
Expand All @@ -11,8 +10,7 @@ import (
func Send(title, body string) error {
switch runtime.GOOS {
case "darwin":
script := fmt.Sprintf(`display notification %q with title %q sound name "default"`, body, title)
return exec.Command("osascript", "-e", script).Run() //nolint:noctx
return exec.Command("osascript", "-e", "display notification", "-e", body, "-e", "with title", "-e", title, "-e", "sound name \"default\"").Run() //nolint:noctx
case "linux":
return exec.Command("notify-send", title, body).Run() //nolint:noctx
default:
Expand Down
Loading