Repository navigation
Conversation
Add server.http_read_timeout and server.http_idle_timeout to the v2 configuration reference. closes #429 Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Verdict: request changes
The PR adds server.http_read_timeout and server.http_idle_timeout to the v2 configuration reference; the defaults (10s / 0s) and the "0s inherits http_read_timeout" semantics correctly match the implementing feature PR (flipt-io/flipt#6695). The one issue is the "Since" version: both rows are marked v2.15.0, but that release does not exist (latest v2 release is v2.14.1) and the feature PR is still open and unmerged, so the version is an unverified guess and the docs would ship options not present in any released Flipt.
docs/v2/configuration/overview.mdx
- major (L173): Both new rows are marked "Since v2.15.0", but that release does not exist — the latest Flipt v2 release is v2.14.1 — and the feature that introduces these settings (flipt-io/flipt#6695) is still open and unmerged, so the
ServerConfigon the v2 branch has nohttp_read_timeout/http_idle_timeoutfields at all. Per this repo's docs reviewer persona, the docs must never guess: a specific introducing version is unverified until the feature ships. Since docs auto-deploy on merge to main, merging now would publish config keys that don't work on any released Flipt v2 version. Either confirm with the Flipt team that these will land in the v2.15.0 release and use exactly that version, or hold this PR until the feature merges and the introducing release is known (also applies to line 174 forhttp_idle_timeout).
🤖 Automated review by the Flipt PR review agent.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add server.http_read_timeout and server.http_idle_timeout to the v2
configuration reference.
closes #429