Try harder to reclaim memory in fmpz_single - #2788
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fmpz
mpzcache is supposed to free slots with more than 64 limbs allocated, but does so with anmpz_reallocwhich isn't guaranteed to actually reclaim the memory.This results in soft memory leaks for complex
fmpzworkloads with big coefficients where more and more coefficients get cached and the huge allocations stay in the pool. The memory can be reclaimed by callingflint_cleanup_master(), but this shouldn't be necessary.The fix is to clear+init instead of realloc.
Demonstration:
Before (note the growing rss):
After: