mpn_mod backend for APRCL + tuning fmpz_is_prime - #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The APRCL primality test gets an
mpn_modbackend for the cyclotomic arithmetic whennis small enough, which is significantly faster than the generic-sizefmpz_modbackend. I also used this opportunity to merge allunity_zpfiles in the APRCL module which really didn't need to be separate.Also improve the criterion for using Pocklington and Morrison.
Done using Claude Fable 5.
This significantly speeds up
fmpz_is_primefor medium input, fixing most of the remaining slowness for this function observed in #2625.Time to check 10 random primes of the respective bit size with
fmpz_is_prime: