feat(i18n): add Hebrew language with RTL layout - #257
Open
yossi-computers wants to merge 1 commit into
Open
yossi-computers wants to merge 1 commit into
yossi-computers wants to merge 1 commit into
Conversation
- Add Hebrew translation (he.json) and Israel flag icon - Mirror the layout for right-to-left languages (dir="rtl"): sidebar on the right, titlebar controls on the left, flipped toggles/selects; the script preview and package ID input stay LTR - Move hardcoded dialog strings (update, OneDrive, restore point, manual packages) into locale keys so every language can translate them - Fix sidebar logo not loading on localized pages (/logo.svg) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
Adds Hebrew (
he) to the app, including a right-to-left layout.Localization
app/src/i18n/locales/he.json(all keys) andapp/public/icons/flags/he.svg(Twemoji flag, same style as the other flags).astro.config.mjsand the languages list.RTL layout (applies only when
dir="rtl", set inLayout.astroforhe)html[dir="rtl"]block at the end ofstyle.css, so LTR languages are unchanged.Translatable dialog strings
main.js/appinstall.js. They are now locale keys (dialog.*,install.manualAdded,install.invalidId) added toen.json.MainPage.astrorenders them into a JSON<script>tag that the scripts read, and the English text stays in the code as a fallback. Other languages fall back to English until translated.Bugfix
src="logo.svg", so it didn't load on localized pages (/he/,/it/, …). It's now/logo.svg.Tested with
npm run buildand a localtauri buildon Windows 11. The Hebrew layout was checked visually. RTL rules are scoped todir="rtl", so LTR styling is unchanged.🤖 Generated with Claude Code