fix: consider strokeWidth when calculating polyline visibility#2184
Merged
JaffaKetchup merged 6 commits intoApr 13, 2026
Merged
Conversation
Member
|
Thanks for submitting this! We'll try to take a look at it as soon as we can :) |
Contributor
Author
|
I fixed the formatting, but I’m not sure how to deal with the scoring issues. |
JaffaKetchup
changed the title
strokeWidth
JaffaKetchup
changed the title
strokeWidthstrokeWidth
JaffaKetchup
changed the title
strokeWidthstrokeWidth when calculating polyline visibility
JaffaKetchup
approved these changes
Mar 14, 2026
Member
There was a problem hiding this comment.
LGTM, thanks! Although would be good to get another @fleaflet/maintainers' review.
This does result in an additional call to metersToScreenPixels (which involves projections) for each polyline+world when it may have been culled before, but if this gives the correct result, it's necessary so its fine.
(Just a note to readers, this doesn't fix the case where polylines disappear to early when the stroke width is 'large' and cullingMargin isn't null and hasn't been increased to account for this.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For thick polylines, setting
cullingMargin: nullis not always sufficient: if all polyline points are outside the viewport, the polyline is not rendered. This can be undesirable in many cases.