Repository navigation
node: Add --no-playwright-browsers flag - #553
Merged
bbhtt merged 1 commit intoOct 22, 2026
Merged
Conversation
Collaborator
|
can you add a test too? |
Contributor
Author
|
sorry wasn't able to get back to this sooner, will provide tests next week |
threema-sebastian
force-pushed
the
add---no-playwright-browsers
branch
from
October 19, 2026 10:19
868e45d to
f9c5f7b
Compare
Contributor
Author
Okay added a test that asserts that no requests went out for playwright if the flag has been passed |
Collaborator
|
CI is failing. |
threema-sebastian
force-pushed
the
add---no-playwright-browsers
branch
from
October 22, 2026 13:27
f9c5f7b to
c188e47
Compare
To avoid fetching the playwright browsers in cases where we don't need them in the final flatpack.
threema-sebastian
force-pushed
the
add---no-playwright-browsers
branch
from
October 22, 2026 13:28
c188e47 to
270e131
Compare
Contributor
Author
Fixed the formatting issue and rebased the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid fetching the playwright browsers in cases where we don't need them in the final flatpack sandbox.