fix: health and external state root fixes #493
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates a set of fixes related to (1) health reporting when L2 engine API calls fail and (2) safer external state root calculation behavior, aligning with findings from the referenced Nethermind security audit items and stacked PRs.
Changes:
- Marks the service as
ServiceUnavailablewhen key L2 engine API calls fail (via a centralhandle_l2_rpc_resulthelper). - Hardens external state root calculation by removing panic-prone assumptions around stored FCU context and by simplifying attribute handling.
- Reduces unnecessary cloning/conversions by directly extracting payload fields for logging/metrics, and expands tests around these scenarios.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
502
to
505
| let l2_result = self | ||
| .l2_client | ||
| .fork_choice_updated_v3(fcu_info.0, Some(new_payload_attrs)) | ||
| .fork_choice_updated_v3(fork_choice_state, Some(new_payload_attrs)) | ||
| .await?; |
| .fork_choice_updated_v3(fork_choice_state, Some(new_payload_attrs)) | ||
| .await?; | ||
|
|
||
| if let Some(new_payload_id) = l2_result.payload_id { |
avalonche
force-pushed
the
ale/health-and-external-state-root
branch
from
July 16, 2026 06:55
d49b456 to
1f96575
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
crates/rollup-boost/src/server.rs:521
calculate_external_state_rootforwards an Engine API FCU call to the L2 client usingawait?, which propagates the error without marking the service as unhealthy. This makes L2 Engine API failures from this path inconsistent with the new health behavior added elsewhere viahandle_l2_rpc_result.
let l2_result = self
.l2_client
.fork_choice_updated_v3(fork_choice_state, Some(new_payload_attrs))
.await?;
avalonche
added a commit
that referenced
this pull request
Jul 16, 2026
Bump rollup-boost 0.7.16 -> 0.7.17. rollup-boost-types unchanged, stays 0.3.0. Since 0.7.16: - flashblocks payload id mismatch fcu race (#491) - require explicit VALID before selecting the builder payload (#492) - health and external state root fixes (#493) - don't reset buffer when fcu without attributes arrive (#495) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
avalonche
added a commit
that referenced
this pull request
Jul 16, 2026
Bump rollup-boost 0.7.16 -> 0.7.17. rollup-boost-types unchanged, stays 0.3.0. Since 0.7.16: - flashblocks payload id mismatch fcu race (#491) - require explicit VALID before selecting the builder payload (#492) - health and external state root fixes (#493) - don't reset buffer when fcu without attributes arrive (#495) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes by @alessandromazza98 in