docs(tests): replace machine-local HF_HOME paths with a placeholder - #58
Merged
Merged
Conversation
Both docstrings told the reader to run with HF_HOME=/nfs/lvyufeng/hf_cache, a path that exists only on one host, so the instruction was a dead end for everyone else. Use <your-hf-cache-dir> and say what it should point at. Docstrings only; no executable lines touched.
zhaoyinglia
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test docstrings instructed the reader to run with
HF_HOME=/nfs/lvyufeng/hf_cache, apath that exists only on one host. For anyone else that makes the documented invocation a
dead end.
tests/integration/test_profiler_qwen3_infer.py(landed in feat(profiler): torch-cuda parity for PrivateUse1 — flows, device time, kernel metadata #55)tests/manual/test_qwen3_ddp_live.py(pre-existing; same one-line pattern, fixed together)Both now use
<your-hf-cache-dir>and state what it should point at.Docstrings only — no executable lines touched. Verified: both files still parse (
ast.parse),ruff checkandruff format --checkclean, and a repo-wide sweep for/nfs/,/root/,/home/<user>over tracked non-plan files now returns nothing.