[CICD] Pass --prefix /usr explicitly in the pip install fallback#36
Open
shiptux wants to merge 1 commit into
Open
[CICD] Pass --prefix /usr explicitly in the pip install fallback#36shiptux wants to merge 1 commit into
shiptux wants to merge 1 commit into
Conversation
…back Same as FlagAttention#35 review feedback: pip's --root without --prefix relies on the build python's install scheme; inside rpmbuild the RPM_BUILD_ROOT site patch forces /usr on Fedora/openEuler, but being explicit removes the dependency on that behavior. Verified: openEuler 24.03 build unchanged (files under /usr/lib/python3.11/site-packages).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #29 (merged). Same review feedback as flagos-ai/FlagAttention#35: the pip fallback's
--rootwithout--prefixrelies on the build python's install scheme. Inside rpmbuild theRPM_BUILD_ROOTsite patch forces the/usrscheme on Fedora/openEuler, so current builds are correct — but being explicit removes the reliance on that distro patch and costs nothing.Tested
openEuler 24.03 container build with this change: output unchanged, files under
/usr/lib/python3.11/site-packages/flagsparse/, install + import OK.