fix: Race-Condition behebt Rezept-Verlust bei Mahlzeiten - #51
Open
fkischewski99 wants to merge 2 commits into
Open
fix: Race-Condition behebt Rezept-Verlust bei Mahlzeiten#51fkischewski99 wants to merge 2 commits into
fkischewski99 wants to merge 2 commits into
Conversation
Actions in SharedEventViewModel were dispatching parallel coroutines that captured stale state, causing later writes to overwrite earlier ones. Additionally, SaveMeal and UpdateAllMeals were fire-and-forget — navigation happened before Firebase writes completed. Fix: Add Mutex to serialize state mutations in onAction(), and await save operations before navigating away from meal and participant screens.
fkischewski99
changed the title
Revert the onNavigateBack parameter changes and keep the original onAction pattern. The Mutex in onAction() is the core fix. Fixed the action order in ParticipantPage (UpdateAllMeals before GoBack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SharedEventViewModel.onAction(): Alle State-Mutationen werden jetzt serialisiert. Der State wird erst innerhalb des Locks gelesen, sodass parallele Aktionen sich nicht mehr gegenseitig überschreiben.NewMealPage): Statt fire-and-forget wirdsaveMealAndAwait()aufgerufen und erst nach erfolgreichem Firebase-Write navigiert.ParticipantPage): Reihenfolge korrigiert (vorher: GoBack → UpdateAllMeals, jetzt: UpdateAllMeals → GoBack) und Save wird abgewartet.Ursache
Aktionen im
SharedEventViewModelstarteten unabhängige Coroutines, die jeweils den State vor demlaunchlasen. Bei schneller Navigation oder schlechtem Internet überschrieb die zweite Aktion das Ergebnis der ersten — Rezeptdaten gingen verloren.Test plan
./gradlew :composeApp:testDebugUnitTest)