feat: add fix init#39
Merged
Merged
Conversation
Akshay-Srivatsan
approved these changes
Jun 24, 2026
Akshay-Srivatsan
left a comment
Akshay-Srivatsan
left a comment
Contributor
There was a problem hiding this comment.
We should probably also switch to using embedded-io traits (which include error support)
This was referenced Jul 2, 2026
Merged
GregoryLi360
added a commit
that referenced
this pull request
Jul 9, 2026
`fix eval <file>` computed correctly but hung on shutdown (closes #40, regression after #39). `Drop` ran before `kernel::shutdown()`, which called the `Close` path for the first time which had 2 bugs: - Host never acked `Close`, but caller expects it and blocks waiting for it - After the host sends the ack response, arca panics with `Err(Closed)` because `Reader::read` reported the pipe being closed before reading the ack Also updated README `just fix eval addblob.fix`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
fix init(creates the.fixstore) on a new in-VMmkdirhost effect, and splits thefixentrypoint intoinitandeval <file>.