Repository navigation
Thrall stands in his throne room: only true rares take points from rare sightings (#2894) - #2926
Merged
Merged
Conversation
…tops logging world bosses as rares Emi (#2894, Ragefire Chasm's pick-up guide): Thrall's hand-in pointed outside the Cleft of Shadow (39.70,61.00) instead of his throne room. The Recorder logged world bosses as `rare` sightings, so the data build gave Thrall the spots where players stood when they saw him (127 Orgrimmar points in the 0.4.1 data, one at 39.71,61.02) and the role `rare`. Data build: a `rare` sighting gives spawn points and the rare role only when it is classed rare or rare elite, or, a vignette's with no class, when the data ranks the NPC rare. Recorder: world bosses are `unit` census records only, no `rare` record (format unchanged). Same-input data builds, before and after: 12 NPCs change, 11 world bosses and Lady Katrana Prestor, each losing the rare role; Thrall 37 -> 5 points, all in the throne room. No other NPC changes. Tests (fail before, pass after): forge-data recordings::tests::a_world_boss_sighting_..._2894, forge-addontest recorder_finds::a_world_boss_seen_is_a_unit_record_..._2894.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2894
Emi's report: Ragefire Chasm's pick-up guide sent Thrall's hand-in (Hidden Enemies, 5727) to Orgrimmar 39.70,61.00, outside the Cleft of Shadow, instead of his throne room. The cause is in the data: the Recorder logged world bosses (the faction leaders) as
raresightings, and the data build took each sighting's position, which is where the player stood, as a spawn point. The 0.4.1 data has Thrall with 127 Orgrimmar points, one at 39.71,61.02, and the rolerare. #2909's grouping cut that to 37 points but kept the sighting-based ones.forge-datarecordings): araresighting gives spawn points and the rare role only when it is classed rare or rare elite, or (a vignette's with no class) when the data ranks the NPC rare. Everything else keeps its normal spawns.rare. They stay in theunitcensus with their classb. The recordings format is unchanged (fewerrarerecords), so older Recorders' recordings are handled by the data build rule above.Fail before, pass after (observed)
The tests ran with the fix's code reversed (tests kept), then on the branch.
recordings::tests::a_world_boss_sighting_gives_no_spawn_points_and_no_rare_role_2894(Thrall)recorder_finds::a_world_boss_seen_is_a_unit_record_and_no_rare_sighting_2894Also run: forge-data
recordings::tests29 pass, forge-addontestrecorder48 pass, clippy-D warningson forge-data and forge-addontest (all targets) clean, rustfmt clean.Same-input data builds, before and after
Two data builds from the same 0.4.1 inputs (QuestieDB 1.1.2, client tables 70888, the recordings archive, built-at 2026-11-17), next's forge and this branch's. NPCs whose spawns or roles differ: 12, no others.
Thrall's five points after: 31.53,37.91 to 32.03,37.69, all in the throne room (the reporter's right spot: 31.90,37.77). The nearest to the reported wrong spot is 24.4 map percent away.
Reaches players with the next data build (the pick-up guides read the Codex, built from this data).
Model and tool: Claude Opus 5.5 via omp