Skip to content

Thrall stands in his throne room: only true rares take points from rare sightings (#2894) - #2926

Merged
fitzforge merged 1 commit into
nextfrom
fix/rare-sightings-true-rares
Nov 18, 2026
Merged

fitzforge merged 1 commit into
nextfrom
fix/rare-sightings-true-rares

Conversation

@fitzforge

Copy link
Copy Markdown
Owner

Fixes #2894

Emi's report: Ragefire Chasm's pick-up guide sent Thrall's hand-in (Hidden Enemies, 5727) to Orgrimmar 39.70,61.00, outside the Cleft of Shadow, instead of his throne room. The cause is in the data: the Recorder logged world bosses (the faction leaders) as rare sightings, and the data build took each sighting's position, which is where the player stood, as a spawn point. The 0.4.1 data has Thrall with 127 Orgrimmar points, one at 39.71,61.02, and the role rare. #2909's grouping cut that to 37 points but kept the sighting-based ones.

  • Data build (forge-data recordings): a rare sighting gives spawn points and the rare role only when it is classed rare or rare elite, or (a vignette's with no class) when the data ranks the NPC rare. Everything else keeps its normal spawns.
  • Recorder: world bosses are no longer logged as rare. They stay in the unit census with their class b. The recordings format is unchanged (fewer rare records), so older Recorders' recordings are handled by the data build rule above.

Fail before, pass after (observed)

The tests ran with the fix's code reversed (tests kept), then on the branch.

Test Without the fix Branch
forge-data recordings::tests::a_world_boss_sighting_gives_no_spawn_points_and_no_rare_role_2894 (Thrall) fail pass
forge-addontest recorder_finds::a_world_boss_seen_is_a_unit_record_and_no_rare_sighting_2894 fail pass

Also run: forge-data recordings::tests 29 pass, forge-addontest recorder 48 pass, clippy -D warnings on forge-data and forge-addontest (all targets) clean, rustfmt clean.

Same-input data builds, before and after

Two data builds from the same 0.4.1 inputs (QuestieDB 1.1.2, client tables 70888, the recordings archive, built-at 2026-11-17), next's forge and this branch's. NPCs whose spawns or roles differ: 12, no others.

NPC Rank Points before -> after Role dropped
Thrall (4949) world boss 37 -> 5 rare
King Magni Bronzebeard (2784) world boss 17 -> 5 rare
Cairne Bloodhoof (3057) world boss 15 -> 4 rare
High Tinker Mekkatorque (7937) world boss 15 -> 4 rare
Varimathras (2425) world boss 22 -> 12 rare
Tyrande Whisperwind (7999) world boss 8 -> 4 rare
Arch Druid Fandral Staghelm (3516) world boss 10 -> 8 rare
Archbishop Benedictus (1284) world boss 4 -> 3 rare
Vol'jin (10540) world boss 5 -> 4 rare
Lady Katrana Prestor (1749) normal 3 -> 3 rare
Lady Jaina Proudmoore (4968) world boss 1 -> 1 rare
Lady Sylvanas Windrunner (10181) world boss 1 -> 1 rare

Thrall's five points after: 31.53,37.91 to 32.03,37.69, all in the throne room (the reporter's right spot: 31.90,37.77). The nearest to the reported wrong spot is 24.4 map percent away.

Reaches players with the next data build (the pick-up guides read the Codex, built from this data).

  • AI agent
    Model and tool: Claude Opus 5.5 via omp

…tops logging world bosses as rares

Emi (#2894, Ragefire Chasm's pick-up guide): Thrall's hand-in pointed outside the Cleft of Shadow
(39.70,61.00) instead of his throne room. The Recorder logged world bosses as `rare` sightings, so the
data build gave Thrall the spots where players stood when they saw him (127 Orgrimmar points in the
0.4.1 data, one at 39.71,61.02) and the role `rare`.

Data build: a `rare` sighting gives spawn points and the rare role only when it is classed rare or
rare elite, or, a vignette's with no class, when the data ranks the NPC rare. Recorder: world bosses
are `unit` census records only, no `rare` record (format unchanged).

Same-input data builds, before and after: 12 NPCs change, 11 world bosses and Lady Katrana Prestor,
each losing the rare role; Thrall 37 -> 5 points, all in the throne room. No other NPC changes.
Tests (fail before, pass after): forge-data recordings::tests::a_world_boss_sighting_..._2894,
forge-addontest recorder_finds::a_world_boss_seen_is_a_unit_record_..._2894.
@fitzforge fitzforge added this to the 0.4.2 milestone Nov 18, 2026
@fitzforge
fitzforge enabled auto-merge November 18, 2026 04:27
@fitzforge
fitzforge merged commit 3b123da into next Nov 18, 2026
11 checks passed
@fitzforge
fitzforge deleted the fix/rare-sightings-true-rares branch November 18, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

marker for thrall in wrong spot

1 participant