Repository navigation
feat(cf-preview): preview_binding_allow can share one Production Secrets Store secret - #88
Merged
Merged
Conversation
…ets Store secret An exact secrets_store_secrets:BINDING=<store_id>/<secret_name> entry waives the Production-collision/denylist check and the high-risk allow requirement for that one binding+identity. A bare kind:BINDING entry never waives the collision; D1 and Shared Dev (dev_binding_allow) are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Preview audit (
auditPreviewConfig/auditProdConfig) now accepts the exact entrysecrets_store_secrets:BINDING=<store_id>/<secret_name>inpreview_binding_allow.preview_deny_resourcescheck for that one binding and identity, and also satisfies the high-risk allow requirement for that binding.secrets_store_secrets:BINDINGstill only satisfies the high-risk check; it does not waive the collision. Mismatching store/secret/binding still fails. D1 never shareable.dev_binding_allow,DEV_SHAREABLE_KINDS) unchanged; newPREVIEW_SHAREABLE_KINDSis local to lib.mjs.scripts/cf-preview/lib.test.mjs; docs indocs/cf-worker-v2.md.Caller string for diet-manager:
secrets_store_secrets:FATSECRET_CLIENT_ID=a2a4a60a04b142d3a0c7d482542e67fc/FATSECRET_CLIENT_ID(and the same forFATSECRET_CLIENT_SECRET).🤖 Generated with Claude Code