Repository navigation
feat(cf-v2): Native Preview uses the shared CLOUDFLARE_API_TOKEN/ACCOUNT_ID - #87
Merged
Merged
Conversation
…UNT_ID Remove the dedicated CLOUDFLARE_PREVIEW_API_TOKEN / CLOUDFLARE_PREVIEW_ACCOUNT_ID from _cf-worker-v2 and _cf-worker-preview-gc (no deprecated alias, no fallback), as PR #76 did for the Dev token. Docs, openspec and contract tests updated. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dedicated
CLOUDFLARE_PREVIEW_API_TOKEN/CLOUDFLARE_PREVIEW_ACCOUNT_IDfrom_cf-worker-v2.ymland_cf-worker-preview-gc.yml. Preview (non-main) now usesCLOUDFLARE_API_TOKEN/CLOUDFLARE_ACCOUNT_ID, same as Production and Dev (precedent: #76). No deprecated alias, no fallback.secrets.CLOUDFLARE_*on every ref.CLOUDFLARE_API_TOKEN/CLOUDFLARE_ACCOUNT_IDnow required.engine.sh) unchanged in behaviour: fails closed with "credentials not provided (set CLOUDFLARE_API_TOKEN and CLOUDFLARE_ACCOUNT_ID)"; Smoke still must not receive credentials.Breaking: callers that still pass the old
CLOUDFLARE_PREVIEW_*secrets will be rejected by GitHub (undeclared secret) and must drop them; Preview GC callers must pass the account pair.Tests: contract, test-jobs, deploy/migrate/smoke/parse-env/probe/gh, node unit tests pass locally. actionlint/shellcheck not installed locally; left to CI.
🤖 Generated with Claude Code