Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current REST API creates
device_poolResources and stores their membership rule indevice_membership_criteria. The SDK still advertised the legacystatic_device_pooltype and discarded that field on reads, blocking Terraform support.Add the current type and carry criteria as
json.RawMessagethrough create, update, get and list. Nil criteria on update preserves existing membership. Keep the old constant as deprecated for source compatibility, and document that pool-member endpoints only accept listed-device criteria.Refresh the Resource/PoolMember portion of the OpenAPI fixture from
firezone/main/elixirat48052865fdbd492eeaf471a8aee3942c4f7bcf17. Update the integration test to create and clean up its own pool instead of depending on portal-created legacy pools.Validation: race tests, vet (including integration-tag compilation), golangci-lint, and OpenAPI conformance checks pass. HTTP tests exercise all four criteria shapes and field preservation. Live integration tests were not run against an account.
Companion dependency for firezone/terraform-provider-firezone#4. Merge this SDK PR first.